Skip to content

Commit

Permalink
fix(menubar): remove incorrect aria-activedescendant
Browse files Browse the repository at this point in the history
- `aria-activedescendant` should identify a visually focused element when the real focus remains on this element.
  In the current implementation it identified selected element (even when the menu is closed), not the focused.
- `aria-activedescendant` is not needed because NcAction has actual focus anyway.
  In case it will be actually needed, it should be implemented in the `NcActions`

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
  • Loading branch information
ShGKme committed Jan 12, 2024
1 parent 9ed7aa0 commit aa18f50
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/components/Menu/ActionList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
:container="menuIDSelector"
:aria-label="labelWithSelected"
:type="state.active ? 'primary': 'tertiary'"
:aria-activedescendant="currentChild ? `${$menuID}-child-${currentChild.key}` : null"
:force-menu="true"
:name="labelWithSelected"
:data-text-action-entry="actionEntry.key"
Expand All @@ -37,7 +36,6 @@
<component :is="icon" :key="iconKey" />
</template>
<ActionSingle v-for="child in children"
:id="`${$menuID}-child-${child.key}`"
:key="`child-${child.key}`"
:active="currentChild?.key === child.key"
is-item
Expand Down

0 comments on commit aa18f50

Please sign in to comment.