Merge pull request #6562 from nextcloud/backport/6508/stable29

[stable29] Fix(plaintext): multiple linebreaks at end
nextcloud · Dec 10, 2024 · abae069 · abae069
2 parents 5f394c6 + 116a483
commit abae069
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/EditorFactory.js b/src/EditorFactory.js
@@ -68,7 +68,14 @@ const createEditor = ({ language, onCreate = () => {}, onUpdate = () => {}, exte
 			FocusTrap,
 		]
 	} else {
-		defaultExtensions = [PlainText, CodeBlockLowlight.configure({ lowlight, defaultLanguage: language })]
+		defaultExtensions = [
+			PlainText,
+			CodeBlockLowlight.configure({
+				lowlight,
+				defaultLanguage: language,
+				exitOnTripleEnter: false,
+			}),
+		]
 	}
 
 	return new Editor({

diff --git a/src/tests/plaintext.spec.js b/src/tests/plaintext.spec.js
@@ -79,4 +79,17 @@ describe('html as plain text', () => {
     expect(plaintextThroughEditor('"\';&.-#><')).toBe('"\';&.-#><')
     expect(plaintextThroughEditor(xssFuzzVectors)).toBe(xssFuzzVectors)
   })
+} )
+
+describe('regression tests', () => {
+	test('tripple enter creates new lines at end (#6507)', () => {
+		const tiptap = createEditor({
+			enableRichEditing: false
+		})
+		tiptap.commands.enter()
+		tiptap.commands.enter()
+		tiptap.commands.enter()
+		expect(serializePlainText(tiptap.state.doc))
+			.toEqual("\n\n\n")
+	})
 })