Skip to content

Commit

Permalink
fix(table): replace InlineActionsContainer by NcActionButtonGroup
Browse files Browse the repository at this point in the history
It has the same styles and correct a11y attributes.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
  • Loading branch information
ShGKme committed Jan 10, 2024
1 parent a15d352 commit ad73420
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 61 deletions.
56 changes: 0 additions & 56 deletions src/components/InlineActionsContainer.vue

This file was deleted.

9 changes: 4 additions & 5 deletions src/nodes/Table/TableHeaderView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<NcActions v-if="editor.isEditable"
ref="menu"
data-text-table-actions="header">
<InlineActionsContainer>
<NcActionButtonGroup>
<NcActionButton data-text-table-action="align-column-left"
:aria-label="t('text', 'Left align column')"
@click="alignLeft">
Expand All @@ -49,7 +49,7 @@
<AlignHorizontalRight />
</template>
</NcActionButton>
</InlineActionsContainer>
</NcActionButtonGroup>
<NcActionButton data-text-table-action="add-column-before"
close-after-click
@click="addColumnBefore">
Expand Down Expand Up @@ -81,8 +81,7 @@

<script>
import { NodeViewWrapper, NodeViewContent } from '@tiptap/vue-2'
import { NcActions, NcActionButton } from '@nextcloud/vue'
import InlineActionsContainer from '../../components/InlineActionsContainer.vue'
import { NcActions, NcActionButton, NcActionButtonGroup } from '@nextcloud/vue'
import {
AlignHorizontalCenter,
AlignHorizontalLeft,
Expand All @@ -99,8 +98,8 @@ export default {
AlignHorizontalLeft,
AlignHorizontalRight,
Delete,
InlineActionsContainer,
NcActionButton,
NcActionButtonGroup,
NcActions,
NodeViewWrapper,
NodeViewContent,
Expand Down

0 comments on commit ad73420

Please sign in to comment.