-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y.js backend enhancements and debug helpers #4310
Conversation
3 failed and 4 flaky tests on run #12081 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The code looks good to me, but I'd prefer if we could get a second review - especially of readVarUint()
in lib/YjsMessage.php
🤓
c70a37f
to
d7d7810
Compare
Conflicts resolved, @max-nextcloud any chance you find some time? Not urgent but trying to get my open pr count down a bit 🙈 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
d7d7810
to
2341059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parsing of the base64 encoded messages and extraction of the first bits to get the types is nicely covered with tests. So I'm confident it's good as it is.
📝 Summary
While looking into #4309 I thought it might be nicer to actually decode parts of the y.js message to perform relevant checks on it. This is now done in the YjsMessage class where so far only the relevant bits for extracting the message type is implemented. Upstream references are left in the code.
In addition I added a few logging parts in comments that might be useful in future debugging/development.
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)