-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Avoid layout jump with rich workspace #4776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
commented
Sep 6, 2023
juliusknorr
commented
Sep 6, 2023
juliusknorr
commented
Sep 6, 2023
3 tasks
juliusknorr
force-pushed
the
enh/rich-workspace-switch
branch
from
September 8, 2023 07:15
0eb23bb
to
23ce8f8
Compare
4 tasks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
juliusknorr
force-pushed
the
enh/rich-workspace-switch
branch
from
September 8, 2023 09:15
23ce8f8
to
bbd5d6d
Compare
juliusknorr
requested review from
max-nextcloud,
luka-nextcloud,
mejo- and
skjnldsv
September 8, 2023 09:25
Will bump OCP composer package once other CI is good :) |
skjnldsv
approved these changes
Sep 8, 2023
Version failures unrealted, fix in nextcloud/server#40348 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/rich-workspace-switch
branch
from
September 8, 2023 12:56
49c1e3d
to
4effe7e
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/rich-workspace-switch
branch
from
September 8, 2023 20:40
cb834be
to
ce0efd6
Compare
Remaining failures unrelated |
🎉🎉🎉🎉🎉 |
8 tasks
@juliushaertl layout jumps does not occur on first page load, however, if you refresh the page or open and close an image from the viewer, layout jump still occurs. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #4254 which uses additional dav properties to already know on initial rendering if space for the rich workspace should be preserved.
In addition we can actually use the webdav markdown response to even show the full file content rendered before the text session is even started. As a follow up we could think about only initializing the session if the user clicks the rich workspace which would save us from lots of requests and problems with rich workspace always being locked.