Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid layout jump with rich workspace #4776

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 6, 2023

Alternative approach to #4254 which uses additional dav properties to already know on initial rendering if space for the rich workspace should be preserved.

In addition we can actually use the webdav markdown response to even show the full file content rendered before the text session is even started. As a follow up we could think about only initializing the session if the user clicks the rich workspace which would save us from lots of requests and problems with rich workspace always being locked.

src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Sep 6, 2023

3 failed and 2 flaky tests on run #12070 ↗︎

3 137 18 0 Flakiness 2

Details:

fix: Avoid layout jump with rich workspace
Project: Text Commit: ce0efd6f00
Status: Failed Duration: 05:13 💡
Started: Sep 8, 2023 8:46 PM Ended: Sep 8, 2023 8:51 PM
Failed  cypress/e2e/attachments.spec.js • 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots
Flakiness  api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

juliusknorr and others added 2 commits September 8, 2023 11:15
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@juliusknorr juliusknorr force-pushed the enh/rich-workspace-switch branch from 23ce8f8 to bbd5d6d Compare September 8, 2023 09:15
@juliusknorr juliusknorr marked this pull request as ready for review September 8, 2023 09:25
@juliusknorr
Copy link
Member Author

Will bump OCP composer package once other CI is good :)

@juliusknorr
Copy link
Member Author

Version failures unrealted, fix in nextcloud/server#40348

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enh/rich-workspace-switch branch from 49c1e3d to 4effe7e Compare September 8, 2023 12:56
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enh/rich-workspace-switch branch from cb834be to ce0efd6 Compare September 8, 2023 20:40
@juliusknorr
Copy link
Member Author

Remaining failures unrelated

@juliusknorr juliusknorr merged commit 91f9e17 into main Sep 8, 2023
40 of 42 checks passed
@juliusknorr juliusknorr deleted the enh/rich-workspace-switch branch September 8, 2023 20:56
@szaimen
Copy link
Contributor

szaimen commented Sep 9, 2023

🎉🎉🎉🎉🎉

@maximelehericy
Copy link

@juliushaertl layout jumps does not occur on first page load, however, if you refresh the page or open and close an image from the viewer, layout jump still occurs.

max-nextcloud added a commit that referenced this pull request Feb 2, 2024
Fixes #5332.

Looks like #4698 brought back the file list header initialization
that had just been moved to an init script in #4776.

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit that referenced this pull request Feb 2, 2024
Fixes #5332.

Looks like #4698 brought back the file list header initialization
that had just been moved to an init script in #4776.

Signed-off-by: Max <max@nextcloud.com>
backportbot bot pushed a commit that referenced this pull request Feb 6, 2024
Fixes #5332.

Looks like #4698 brought back the file list header initialization
that had just been moved to an init script in #4776.

Signed-off-by: Max <max@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants