Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change three dots to an ellipsis #4777

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Change three dots to an ellipsis #4777

merged 1 commit into from
Sep 6, 2023

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Sep 6, 2023

No description provided.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet Valdnet self-assigned this Sep 6, 2023
@juliusknorr juliusknorr added bug Something isn't working 4. to release labels Sep 6, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Sep 6, 2023
@cypress
Copy link

cypress bot commented Sep 6, 2023

3 failed and 3 flaky tests on run #12052 ↗︎

3 137 18 0 Flakiness 3

Details:

Change three dots to an ellipsis
Project: Text Commit: c5d3dfc999
Status: Failed Duration: 05:06 💡
Started: Sep 6, 2023 3:49 PM Ended: Sep 6, 2023 3:55 PM
Failed  cypress/e2e/attachments.spec.js • 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Shares the file as a public read only link Output Screenshots
Flakiness  nodes/Table.spec.js • 1 flaky test

View Output Video

Test Artifacts
table plugin > Enter creates newline and navigates Output Screenshots
Flakiness  api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr merged commit a025fda into main Sep 6, 2023
29 of 31 checks passed
@juliusknorr juliusknorr deleted the Valdnet-patch-1 branch September 6, 2023 17:03
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants