fix: Rework attachment tests

[juliusknorr]

One local failure remaining which seems related to recent getParent changes:

{
  "reqId": "9fD20dHDE2aTMruVxttA",
  "level": 3,
  "time": "2023-09-06T17:10:52+00:00",
  "remoteAddr": "192.168.21.1",
  "user": "yztziuuoda",
  "app": "no app in context",
  "method": "MOVE",
  "url": "/remote.php/dav/files/yztziuuoda/test.md",
  "message": "",
  "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36",
  "version": "28.0.0.2",
  "exception": {
    "Exception": "OCP\\Files\\NotFoundException",
    "Message": "",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/html/lib/private/Files/Node/Node.php",
        "line": 303,
        "function": "getFileInfo",
        "class": "OC\\Files\\Node\\Node",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/text/lib/Service/AttachmentService.php",
        "line": 630,
        "function": "getParent",
        "class": "OC\\Files\\Node\\Node",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/text/lib/Listeners/BeforeNodeRenamedListener.php",
        "line": 54,
        "function": "moveAttachments",
        "class": "OCA\\Text\\Service\\AttachmentService",
        "type": "->",
        "args": [
          [
            "OC\\Files\\Node\\File"
          ],
          [
            "OC\\Files\\Node\\NonExistingFile"
          ]
        ]
      },
      {
        "file": "/var/www/html/lib/private/EventDispatcher/ServiceEventListener.php",
        "line": 86,
        "function": "handle",
        "class": "OCA\\Text\\Listeners\\BeforeNodeRenamedListener",
        "type": "->",
        "args": [
          [
            "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
          ]
        ]
      },
      {
        "file": "/var/www/html/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
        "line": 230,
        "function": "__invoke",
        "class": "OC\\EventDispatcher\\ServiceEventListener",
        "type": "->",
        "args": [
          [
            "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
          ],
          "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent",
          [
            "Symfony\\Component\\EventDispatcher\\EventDispatcher"
          ]
        ]
      },
      {
        "file": "/var/www/html/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
        "line": 59,
        "function": "callListeners",
        "class": "Symfony\\Component\\EventDispatcher\\EventDispatcher",
        "type": "->",
        "args": [
          [
            [
              "Closure"
            ],
            [
              "Closure"
            ]
          ],
          "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent",
          [
            "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
          ]
        ]
      },
      {
        "file": "/var/www/html/lib/private/EventDispatcher/EventDispatcher.php",
        "line": 94,
        "function": "dispatch",
        "class": "Symfony\\Component\\EventDispatcher\\EventDispatcher",
        "type": "->",
        "args": [
          [
            "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
          ],
          "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
        ]
      },
      {
        "file": "/var/www/html/lib/private/EventDispatcher/EventDispatcher.php",
        "line": 106,
        "function": "dispatch",
        "class": "OC\\EventDispatcher\\EventDispatcher",
        "type": "->",
        "args": [
          "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent",
          [
            "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
          ]
        ]
      },
      {
        "file": "/var/www/html/lib/private/Files/Node/HookConnector.php",
        "line": 175,
        "function": "dispatchTyped",
        "class": "OC\\EventDispatcher\\EventDispatcher",
        "type": "->",
        "args": [
          [
            "OCP\\Files\\Events\\Node\\BeforeNodeRenamedEvent"
          ]
        ]
      },
      {
        "file": "/var/www/html/lib/private/legacy/OC_Hook.php",
        "line": 105,
        "function": "rename",
        "class": "OC\\Files\\Node\\HookConnector",
        "type": "->",
        "args": [
          [
            "/test.md",
            "/testMoved.md",
            true
          ]
        ]
      },
      {
        "file": "/var/www/html/lib/private/Files/View.php",
        "line": 755,
        "function": "emit",
        "class": "OC_Hook",
        "type": "::",
        "args": [
          "OC_Filesystem",
          "rename",
          [
            "/test.md",
            "/testMoved.md",
            true
          ]
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/Connector/Sabre/Node.php",
        "line": 159,
        "function": "rename",
        "class": "OC\\Files\\View",
        "type": "->",
        "args": [
          "/test.md",
          "/testMoved.md"
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Tree.php",
        "line": 153,
        "function": "setName",
        "class": "OCA\\DAV\\Connector\\Sabre\\Node",
        "type": "->",
        "args": [
          "testMoved.md"
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
        "line": 612,
        "function": "move",
        "class": "Sabre\\DAV\\Tree",
        "type": "->",
        "args": [
          "files/yztziuuoda/test.md",
          "files/yztziuuoda/testMoved.md"
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "httpMove",
        "class": "Sabre\\DAV\\CorePlugin",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ]
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 472,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "method:MOVE",
          [
            [
              "Sabre\\HTTP\\Request"
            ],
            [
              "Sabre\\HTTP\\Response"
            ]
          ]
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 253,
        "function": "invokeMethod",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ]
        ]
      },
      {
        "file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 321,
        "function": "start",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/lib/Server.php",
        "line": 366,
        "function": "exec",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/appinfo/v2/remote.php",
        "line": 35,
        "function": "exec",
        "class": "OCA\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/remote.php",
        "line": 172,
        "args": [
          "/var/www/html/apps/dav/appinfo/v2/remote.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/html/lib/private/Files/Node/Node.php",
    "Line": 112,
    "CustomMessage": "--"
  }
}

[cypress]

4 failed and 3 flaky tests on run #12054 ↗︎

4

136

18

0

3

Details:

fix: Rework attachment tests
Project: Text	Commit: c36ff89d7b
Status: Failed	Duration: 06:38 💡
Started: Sep 6, 2023 5:28 PM	Ended: Sep 6, 2023 5:35 PM

  cypress/e2e/attachments.spec.js • 4 failed tests

View Output Video

Test		Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file		Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file		Output Screenshots
Test all attachment insertion methods > test if attachment folder is deleted after having deleted a markdown file		Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side		Output Screenshots

  attachments.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Test all attachment insertion methods > Insert an image file from Files		Output Screenshots

  share.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Open test.md in viewer > Share a file with download disabled shows an error		Output Screenshots

  api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Sync service provider > recovers from a dropped message		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}