Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleting rich workspaces readme.md #4782

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Sep 7, 2023

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud added bug Something isn't working 3. to review labels Sep 7, 2023
@luka-nextcloud luka-nextcloud self-assigned this Sep 7, 2023
@cypress
Copy link

cypress bot commented Sep 7, 2023

3 failed and 1 flaky tests on run #12061 β†—οΈŽ

3 137 18 0 Flakiness 1

Details:

fix: deleting rich workspaces readme.md
Project: Text Commit: 5af1cd1588
Status: Failed Duration: 04:48 πŸ’‘
Started: Sep 7, 2023 4:49 PM Ended: Sep 7, 2023 4:54 PM
FailedΒ  cypress/e2e/attachments.spec.js β€’ 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
FlakinessΒ  cypress/e2e/files.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle markdown with richtext editor Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud
Copy link
Collaborator

Code looks good. Cypress test would be nice to avoid regressions in the future.

@juliusknorr juliusknorr force-pushed the bugfix/deleting-readme branch from c689613 to ee7d1ba Compare September 14, 2023 09:50
@luka-nextcloud
Copy link
Contributor Author

luka-nextcloud commented Sep 19, 2023

@max-nextcloud @juliushaertl I found that cypress tests for workspace was set to skip here
Should we enable them again?
It seems like there are many errors while enabling them. Please check below screenshot. Should we fix them in this PR?
Test case for above issue already included in case "Hides the workspace when switching to another view". But need small update.

image

@mejo-
Copy link
Member

mejo- commented Sep 21, 2023

@luka-nextcloud I agree that we certainly should re-enalble the Cypress tests for rich workspaces. Seems like skipping them was meant as temporary in db7aa50 anyway. Maybe you can take a look at fixing the Cypress tests?

@max-nextcloud
Copy link
Collaborator

I think a first step towards this would be running the current master branch locally and checking how rich workspaces work there. Maybe some of the functionality is still missing.

@luka-nextcloud
Copy link
Contributor Author

@mejo- @max-nextcloud I'd suggest to open a separate ticket for the cypress work, what do you think?

@mejo-
Copy link
Member

mejo- commented Oct 2, 2023

@luka-nextcloud I'm fine with this. Could you open the issue?

@luka-nextcloud
Copy link
Contributor Author

Here's a separate ticket: #4829

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr juliusknorr force-pushed the bugfix/deleting-readme branch from ee7d1ba to ddca577 Compare October 26, 2023 19:06
@juliusknorr juliusknorr merged commit 2213539 into main Oct 27, 2023
35 checks passed
@juliusknorr juliusknorr deleted the bugfix/deleting-readme branch October 27, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading error after deleting rich workspaces readme.md
4 participants