Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(SyncService): Throw error on save failure #4836

Merged
merged 1 commit into from
Oct 11, 2023
Merged

enh(SyncService): Throw error on save failure #4836

merged 1 commit into from
Oct 11, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Oct 10, 2023

This allows to detect errors when saving via the editor API.

Outsourced from #4780:

I had a look at all occasions of .save(), .autosave() and .forceSave(). Seems to be mostly places where throwing an error should be save. But maybe it's better to remove this potentially dangerous change from this PR that is supposed to be backported and move it to a seperate PR that doesn't get backported.

@mejo- mejo- added enhancement New feature or request 3. to review labels Oct 10, 2023
@mejo- @juliusknorr
enh(SyncService): Throw error on save failure
24ada4f 
This allows to detect errors when saving via the editor API.

Signed-off-by: Jonas <jonas@freesources.org>
@juliusknorr juliusknorr merged commit c6bda37 into main Oct 11, 2023
22 of 24 checks passed
@juliusknorr juliusknorr deleted the enh/save_throw_error branch October 11, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mejo- @juliusknorr