-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to native browser tooltips #5174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good at first sight but I noticed some problems when trying it out:
- Session List "Active People" is not shown anymore
- Emoji Picker menubar entry has no tooltip and funny color on dark background
- edit guest user name also has color issues on dark background.
I'm not sure if the funny colors are related or not. Will try with current master and provide screen shots.
Funny color in guest name entry also exists on stable28. So not caused by this. |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2656067
to
1c24ead
Compare
@luka-nextcloud did you test the image insertion, active people and link picker? |
@max-nextcloud I have just checked again. It works well: |
/backport to stable28 |
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)