Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to native browser tooltips #5174

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

luka-nextcloud
Copy link
Contributor

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good at first sight but I noticed some problems when trying it out:

  • Session List "Active People" is not shown anymore
  • Emoji Picker menubar entry has no tooltip and funny color on dark background
  • edit guest user name also has color issues on dark background.

I'm not sure if the funny colors are related or not. Will try with current master and provide screen shots.

@max-nextcloud
Copy link
Collaborator

Missing title in session list

Before: Now:
Bildschirmfoto vom 2023-12-29 22-00-00 grafik

Current Markup (notice data-original-title):
Bildschirmfoto vom 2023-12-29 22-00-46

Funny color, no tooltip in emoji picker

grafik

Funny colors in guest name - tooltip is fine

Bildschirmfoto vom 2023-12-29 21-57-30

@max-nextcloud
Copy link
Collaborator

Funny color in guest name entry also exists on stable28. So not caused by this.

@juliusknorr juliusknorr added bug Something isn't working accessibility labels Jan 2, 2024
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the feature/switch-to-native-tooltips branch from 2656067 to 1c24ead Compare January 3, 2024 18:29
@max-nextcloud
Copy link
Collaborator

@luka-nextcloud did you test the image insertion, active people and link picker?
They still don't show for me.
I checked out the branch, booted the nextcloud-docker-dev for server master, compiled the js and checked there.

@luka-nextcloud
Copy link
Contributor Author

luka-nextcloud commented Jan 4, 2024

@max-nextcloud I have just checked again. It works well:
image
image
image

@juliusknorr juliusknorr merged commit 2da87be into main Jan 4, 2024
52 checks passed
@juliusknorr juliusknorr deleted the feature/switch-to-native-tooltips branch January 4, 2024 21:51
@juliusknorr
Copy link
Member

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to native browser tooltips
3 participants