Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mention): use new url schema #5302

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(mention): use new url schema #5302

merged 1 commit into from
Jan 22, 2024

Conversation

max-nextcloud
Copy link
Collaborator

πŸ“ Summary

Fixes notifications for mentions in 28 and following.

πŸ–ΌοΈ Screenshots

Test mentioning users -- Select a user will insert the mention (failed)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator Author

/backport to stable28

@max-nextcloud max-nextcloud added this to the Nextcloud 29 milestone Jan 22, 2024
@max-nextcloud max-nextcloud added tests If you write them we β™₯ you 3. to review bug Something isn't working bug: regression labels Jan 22, 2024
@juliusknorr
Copy link
Member

Thanks for looking into that Max :)

@juliusknorr juliusknorr merged commit 9a75b21 into main Jan 22, 2024
53 checks passed
@juliusknorr juliusknorr deleted the fix/404-on-mention branch January 22, 2024 07:34
Copy link

backportbot bot commented Jan 22, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/5302/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 711258d7c9308b51956f1193283d9bb31d644908

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5302/stable28

Error: Failed to push branch backport/5302/stable28: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr
Copy link
Member

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working tests If you write them we β™₯ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants