-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): add row, column buttons outside of table #6540
Conversation
Seems like a user interface change so please provide some screenshots ;) |
Yes, I will. It's not yet ready for review. |
ae3ed5a
to
1325ace
Compare
@nextcloud/designers Could you please give me your feedback regarding the button? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
When a new row or column gets added, it should also get focused. The first relevant cell, so leftmost for new rows and topmost for new columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general works really well, thanks for tackling this. I have left some comments in the code. Also I think a cypress test that adds a row or column using one of the buttons would be great to avoid regressions later on.
Signed-off-by: Luka Trovic <luka@nextcloud.com>
1325ace
to
32a41b4
Compare
demo.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works really well now. Only one remaining question because I don't understand why it belongs into this PR. But not a blocker
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)