Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add row, column buttons outside of table #6540

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Oct 17, 2024

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • check if rows and columns can be added / removed and disable buttons accordingly
  • drop colspan=1, rowspan=1, etc from rendered html - first attempt at this failed

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr
Copy link
Member

Seems like a user interface change so please provide some screenshots ;)

@luka-nextcloud
Copy link
Contributor Author

Yes, I will. It's not yet ready for review.

@luka-nextcloud
Copy link
Contributor Author

Screenshot & video
image

demo.webm

@luka-nextcloud luka-nextcloud added enhancement New feature or request 3. to review labels Oct 22, 2024
@luka-nextcloud
Copy link
Contributor Author

@nextcloud/designers Could you please give me your feedback regarding the button? :)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

When a new row or column gets added, it should also get focused. The first relevant cell, so leftmost for new rows and topmost for new columns.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general works really well, thanks for tackling this. I have left some comments in the code. Also I think a cypress test that adds a row or column using one of the buttons would be great to avoid regressions later on.

src/css/prosemirror.scss Outdated Show resolved Hide resolved
src/css/prosemirror.scss Outdated Show resolved Hide resolved
src/nodes/Table/TableView.vue Outdated Show resolved Hide resolved
src/nodes/Table/TableView.vue Outdated Show resolved Hide resolved
src/nodes/Table/TableView.vue Outdated Show resolved Hide resolved
src/nodes/Table/TableCell.js Show resolved Hide resolved
src/nodes/Table/TableView.vue Outdated Show resolved Hide resolved
src/nodes/Table/TableView.vue Show resolved Hide resolved
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud
Copy link
Contributor Author

demo.webm

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works really well now. Only one remaining question because I don't understand why it belongs into this PR. But not a blocker ☺️

src/nodes/Table/TableCell.js Show resolved Hide resolved
@mejo- mejo- merged commit 01c6b2f into main Nov 13, 2024
61 checks passed
@mejo- mejo- deleted the table-tweaks branch November 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Table tweaks
4 participants