Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outline): fix mobile detection and box shadow #6728

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(outline): fix mobile detection and box shadow #6728

merged 1 commit into from
Dec 5, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Dec 3, 2024

Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-
fix(outline): fix mobile detection and box shadow
b589424 
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added bug Something isn't working 3. to review labels Dec 3, 2024
@mejo- mejo- self-assigned this Dec 3, 2024
@mejo- mejo- requested a review from max-nextcloud as a code owner December 3, 2024 13:42
@mejo- mejo- requested a review from elzody December 3, 2024 13:43
@mejo-
Copy link
Member Author

mejo- commented Dec 3, 2024

/backport to stable30

@mejo-
Copy link
Member Author

mejo- commented Dec 3, 2024

/backport to stable29

elzody
elzody approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it before and after on my end on mobile, looks much better

@juliusknorr juliusknorr merged commit 4cb6ba3 into main Dec 5, 2024
62 checks passed
@juliusknorr juliusknorr deleted the fix/outline_mobile branch December 5, 2024 21:05
This was referenced Dec 5, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels
3. to review bug Something isn't working
Projects
📝 Office team
Status: ☑️ Done
Milestone
No milestone
3 participants
@mejo- @elzody @juliusknorr