Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] Fix(debug): remove component in beforeDestroy hook #6756

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 8, 2024

Backport of #6737

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review labels Dec 8, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.11 milestone Dec 8, 2024
@max-nextcloud max-nextcloud force-pushed the backport/6737/stable29 branch from 057d489 to ede111d Compare December 9, 2024 09:51
* Use a set so components can only be in there once.

* Debug data can be written even if syncService is undefined.

Signed-off-by: Max <max@nextcloud.com>

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the backport/6737/stable29 branch from ede111d to 3aa227e Compare December 9, 2024 09:51
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the backport.

@max-nextcloud max-nextcloud marked this pull request as ready for review December 9, 2024 09:52
@mejo- mejo- disabled auto-merge December 10, 2024 14:26
@mejo- mejo- merged commit 4951663 into stable29 Dec 10, 2024
59 of 61 checks passed
@mejo- mejo- deleted the backport/6737/stable29 branch December 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants