-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for vite serve
#6765
base: main
Are you sure you want to change the base?
Conversation
0eb33fa
to
3dd2f2f
Compare
Thanks a lot for looking into this. ❤️ I'm super happy this works. I have two suggestions:
|
I tried to follow the instructions. However now I am seeing this in the proxy logs:
Maybe the ip addresses are different for me? Update ahh... reading helps
|
Thanks for testing it out @max-nextcloud. I added support for a nginx config drop-in to nextcloud-docker-dev in the meantime: juliusknorr/nextcloud-docker-dev#367 This approach is also the reason why I'd keep the default port of
Yes, that's adjusted now as well. The PR to |
Fixes: #6732 Signed-off-by: Jonas <jonas@freesources.org>
Use the same filename for source file and compiled asset. Signed-off-by: Jonas <jonas@freesources.org>
3dd2f2f
to
8219fa3
Compare
Fixes: #6732
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)