Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content-Type response header for JSON responses #90

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

dlichtenberger
Copy link
Contributor

Fixes #88

@dlichtenberger
Copy link
Contributor Author

So some updater tests fail, but the error message seems to indicate that this has nothing to do with this PR:

Exception: Updates between multiple major versions and downgrades are unsupported.

@MorrisJobke
Copy link
Member

So some updater tests fail, but the error message seems to indicate that this has nothing to do with this PR:

Exception: Updates between multiple major versions and downgrades are unsupported.

Yep. Seems that we linked the wrong URL and those now ship a new version of Nextcloud to which the upgrade is not supported. Sadly currently I have limited time to look into this. I will do so later.

@MorrisJobke MorrisJobke self-requested a review May 22, 2017 00:16
@MorrisJobke MorrisJobke self-assigned this May 22, 2017
@PVince81
Copy link
Member

PVince81 commented Feb 26, 2021

@dlichtenberger I know it's old. If you'd still like to get this in please rebase or recreate.

I've just fixed the test problems on master so your PR should be green on the next run.

@solracsf
Copy link
Member

/rebase

@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
Copy link
Collaborator

come-nc commented Oct 23, 2023

I think DCO is not a big deal on a one-line change like this?
And the test failure is not related.
Can someone with power force merge this?

@joshtrichards
Copy link
Member

I set the DCO test to pass and updated to latest master. All tests passing.

@Altahrim Altahrim merged commit 44beafb into nextcloud:master Nov 8, 2023
23 checks passed
Altahrim added a commit that referenced this pull request Nov 9, 2023
Initial work in #90

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON response without Content-Type
9 participants