Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup code #103

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

fix: cleanup code #103

wants to merge 27 commits into from

Conversation

ooliver1
Copy link
Member

Plans:

  • Module for code
  • Bot subclass with startup func for client session
  • Consistency of style
  • Pre-commit to help with a consistent style
  • Allow people to turn off linking loops so they dont destroy test servers by accident
  • Not use questionable import styles (like the ones in link and autopaste, wtf epic)
  • Use proper cog related constants
  • Use _ for unused variables
  • Resolve pyright basic type issues

@TAG-Epic
Copy link
Contributor

Why should this be a module?

MaskDuck
MaskDuck suggested changes Jun 11, 2022
View reviewed changes
previous/__main__.py Outdated Show resolved Hide resolved
previous/cogs/errors.py
elif isinstance(error, MissingRole):
role = ctx.guild.get_role(int(error.missing_role)) # type: ignore
await ctx.send(f'"{role.name}" is required to use this command.') # type: ignore
else:

This comment was marked as off-topic.

Sign in to view

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply transferred the current error handler, half out of scope even though this entire PR is quite feature/fix creep

This comment was marked as off-topic.

Sign in to view

@ooliver1
Copy link
Member Author

Why should this be a module?

All the code in one encapsulated place, who get main.py lost in config and meta files when it can be in one place

ooliver1 added 20 commits June 20, 2022 20:51
@ooliver1
Merge branch 'master' of https://github.com/nextcord/previous into oo…
f6a09e8 
…liver1/fix/cleanup
@ooliver1
style(paste): sort out imports and format
874e1c6
@ooliver1
refactor(paste): use one maintainable dictionary
be891d3
@ooliver1
refactor(paste): use new style typehints
8cf5c1f
@ooliver1
style: use bot subclass for typehints
46009e1
@ooliver1
refactor(paste): remove type ignore
a9eea4f
@ooliver1
fix(autothread): allow env var to not be set
9d47ea0
@ooliver1
fix(autothread): it will not be none but 0
e81805f
@ooliver1
fix(link): use getenv to allow var to be not set
eb89cb7
@ooliver1
feat(link): actually make groups useful
c2de141
@ooliver1
refactor(link): use a non-cog for data storage
3f029e7
@ooliver1
fix(link): raise errors if configuration invalid
baaa769
@ooliver1
refactor(ddocs): fix up style and shorten function
792cb56
@ooliver1
fix(docs): resolve type issues and cleanup
475a525
@ooliver1
style(etc): cleanup format
1fab5c9
@ooliver1
chore: typehint ctx in charinfo
8ed7839
@ooliver1
fix(help): pyright type issues
f4cc039
@ooliver1
fix(help): allow env vars to be none
d2e794b
@ooliver1
fix(stars): pyright issues
9a0bf48
@ooliver1
style: use newer typehint styling
d317006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskDuck MaskDuck MaskDuck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ooliver1 @TAG-Epic @MaskDuck