-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More cleanup before v2.0.0 #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version.go
Outdated
Comment on lines
10
to
13
// VERSION of Nextmv SDK. | ||
// | ||
//go:embed VERSION | ||
var versionFallback string | ||
|
||
// VERSION of Nextmv SDK. | ||
var VERSION = getVersion() | ||
|
||
func getVersion() string { | ||
// Get version from module dependency. | ||
bi, ok := debug.ReadBuildInfo() | ||
if !ok { | ||
// If this happens, we're not running in a module context. We default to | ||
// returning the fallback version. | ||
return versionFallback | ||
} | ||
|
||
for _, dep := range bi.Deps { | ||
// We only care about this repo being used as a dependency. | ||
if !strings.HasPrefix(dep.Path, "github.com/nextmv-io/sdk") { | ||
continue | ||
} | ||
|
||
return dep.Version | ||
} | ||
|
||
// If this happens, we're running in a module in which sdk is not a | ||
// dependency. In this case, we expect the NEXTMV_SDK_OVERRIDE_VERSION to be | ||
// set. Thus, this is unexpected. So, return a string that helps us find the | ||
// way back here. | ||
return "no-overridden-version-found" | ||
} | ||
var VERSION string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to drop this? This still works fine and is more accurate. We only need to shuffle it around to fallback to VERSION
instead of "no-overridden-version-found"
.
merschformann
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More cleanup:
go.mod
to use Go 1.21.