Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more specific guidelines to symbols intro definition #1074

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

RussBerg
Copy link
Contributor

resolves #1000, a more explicit description of the symbols table is given along with some examples to help clarify those descriptions.

@RussBerg RussBerg requested a review from prjemian June 13, 2022 20:49
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as noted

@prjemian prjemian added this to the NXDL 2022.06 milestone Jun 14, 2022
@RussBerg RussBerg marked this pull request as draft June 14, 2022 17:51
@RussBerg RussBerg marked this pull request as ready for review June 14, 2022 19:25
@prjemian prjemian changed the title added more pecific guidelines to symbols intro definition added more specific guidelines to symbols intro definition Jun 15, 2022
@prjemian prjemian self-requested a review June 15, 2022 19:49
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prjemian prjemian merged commit eb71bad into main Jun 15, 2022
@prjemian prjemian deleted the 1000_symbol_table_doc branch June 23, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify use of the symbols table in a NXDL file
2 participants