Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to HTML pages of manual #1256

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Add favicon to HTML pages of manual #1256

merged 5 commits into from
Jun 21, 2023

Conversation

PeterC-DLS
Copy link
Contributor

Remove extra copy of icon

@PeterC-DLS PeterC-DLS requested a review from a team May 3, 2023 17:22
@rayosborn
Copy link
Contributor

I downloaded the favicon, and it appears to be striped. I also believe that it is now recommended to have larger (e.g., 128x128) images, whereas this is 32x32. This is the favicon file we use for NeXpy documentation.

@PeterC-DLS
Copy link
Contributor Author

Thanks for that, Ray, or the one from our main site: https://github.com/nexusformat/wiki/blob/master/public/favicon.ico . Is the www/ directory used anywhere these days?

@prjemian
Copy link
Contributor

prjemian commented May 3, 2023

@FreddieAkeroyd Can you answer this?

Is the www/ directory used anywhere these days?

@rayosborn
Copy link
Contributor

The current website favicon is certainly better than the striped version although it's still only 32x32. Apparently, larger favicons are now used to generate mobile browser shortcuts, so sizes of up to 180x180 (and even 512x512) are recommended on different websites.

We also don't have consistent branding of our websites at the moment. The main landing page looks completely different from the manual. Deciding which we prefer might govern the choice of icon. Not a high priority perhaps, but it would look more professional if we had more homogeneous styling. Future code camp?

@PeterC-DLS
Copy link
Contributor Author

Ok, will leave the re-styling of the whole site to another issue. But will reuse existing favicon from main site.

Copy link
Contributor

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual and impatient-guide are two independent documentations with their own sphinx configuration file. Can we put shared resources (currently only the flavicon) somewhere else (not in ./manual neither in ./impatient-guide)?

@PeterC-DLS PeterC-DLS force-pushed the add-favicon-for-manual branch 2 times, most recently from a92c71c to 43735f4 Compare June 20, 2023 15:40
@PeterC-DLS PeterC-DLS requested a review from a team June 20, 2023 15:47
Copy link
Contributor

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterC-DLS PeterC-DLS merged commit 7e77c30 into main Jun 21, 2023
4 checks passed
@PeterC-DLS PeterC-DLS deleted the add-favicon-for-manual branch June 21, 2023 07:22
newville pushed a commit to newville/definitions that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants