-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding links to first references of the vocabulary items #1272
Conversation
If base class reference is the same as the first reference, do not duplicate the information and have the same link listed twice |
Discussion from Code Camp:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to refactor nexus.py to separate out the xml tree parsing and form another PR to add the nexus_file
utility with its h5py dependency?
Override linking has been modified, and collapsible documentation/enumeration has been added according to the CC discussion. |
Could you rebase this change off the newly refactored method in nxdl_utils.py? This will remove the dependencies on h5py and click |
yes, sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I build the python package, it has a version of 0.0.0
. Perhaps set it to something other than the default.
Fixes automatic versioning
@PeterC-DLS You should now get a correct version when building the package |
@@ -0,0 +1,854 @@ | |||
# pylint: disable=too-many-lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has the same issues as mentioned in in-depth review performed in https://github.com/nexusformat/definitions/pull/1303/files#diff-42efc233d0fece860f874809d0c5b425905ff3341504af645d3f205b628cb5a4
Superseded by #1303 |
No description provided.