Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML errors: make file and line more clear #1289

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Jun 20, 2023

Closes #1266

After this PR, the following error messages are produced

XML validation error

# .../definitions/base_classes/NXaperture.nxdl.xml

<group type="NXtransformations" forbidden="forbidden">
...
</group>
E           dev_tools.globals.errors.XMLSyntaxError: 
E             .../definitions/base_classes/NXaperture.nxdl.xml
E             Element '{http://definition.nexusformat.org/nxdl/3.1}group', attribute 'forbidden': 
E             The attribute 'forbidden' is not allowed., line 51

XML syntax error

# .../definitions/base_classes/NXaperture.nxdl.xml

<group type="NXtransformations"
...
</group>
E           dev_tools.globals.errors.XMLSyntaxError: 
E             .../definitions/base_classes/NXaperture.nxdl.xml
E             error parsing attribute name, line 52, column 7 (NXaperture.nxdl.xml, line 52)

Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful

@woutdenolf woutdenolf merged commit 5dcb885 into nexusformat:main Jun 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NXDL parsing exceptions missing necessary details
2 participants