Fix NXroot nxdl #1321
Closed
Fix NXroot nxdl #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial fix to MPES structure on html page
…onal-geometry-based microstructures
…to nyaml2nxdl-migration
… requested during code camp
…rporate design colours, added chopping of too long first lines of docstrings, added acknowledgements of the dfg and the nfdi on the front page
Regeneration of the nexus file for fixing the changes coming from old…
Activated collapsible docstrings, change page width, added fairmat co…
Crystal structure: single crystals, unit cells, and rotation sets
Since we have substantial changes on the NXsample base class now, here we remove any changes to NXsample in this PR.
Mpes readd base classes
Adds bias to NXmpes
Necessary fixes spotted during test update-north-markus feature branch prior merging into nomadfg
* Add appdef/bc yaml files to gitignore * Improve Makefile for nxdl build * Tricking make to avoid circular dependency * Generalization and cleanup * Change chmod 755 to 644 for NXentry * Reintroduce for-loop for make nyaml * Adds push to github pages * Set correct docs dir * Prepare building * Change id to name * Build and deploy * Push pages to fairmat-docs * Adds clean flag * Use docs folder * Target fairmat branch to rebuild live-docs * Removes old workflows * Updates color and logo * Optimise styling * Add logo padding * Run ci on pr * Adds cleanup ci * Removes yaml files from .gitignore
Changes two links in FAIRmat-NeXus Proposal cover page
* Re-adds yaml files * Adds ci/cd check for yaml files * Fix ci yaml file * Install nyaml2nxdl * Install locally to get correct xsd path * Use python 3.9 and ubuntu-latest * Introduce intentional async between NXmpes.nxdl and NXmpes.yaml for testing * Reverts NXmpes test changes * Sets proper date for cleaning pages * Check request changes token * Don't request changes if not clean * Restore NXmpes sync * Adds _parsed.yaml files to .gitignore * Updates favicon
* Adds multiple input axis and doi reference * Adds input and output paths * Adds NXidentifier * Update fit_function docstring * Updates from review * Explicitly state naming rules * Remove dim for input_SYMBOL * Adds dim before attributes * Use NXcite * Remove requiredness of doi * Updates NXcalibration to use method, reference and object * Add MAPPING * Updates docstring for calibration references * Docstring refinements
* fixing imports
* Modification for changes request from 1303 PR.
* changes from Peter and Pete.
* Change request in nyaml2nxdl_backward_tools.py
* nyaml2nxdl backward tools: fixing requested changes in that file.
* Updating nyaml2nxdl.py with '--do-not-store-nxdl'
* Removed unused and not functioned functions ('append_yaml', 'compaire_niac_and_my'), and CLI options.
* Updating nyaml_forward_tools.py.
* Improved Makefile from fairmat branch
* Removes unused code
* Addresses some review comments in nxdl_utils
* Addresses comments in nxdl_utils
* Fixes typo in readme
* Updating nyam2nxdl converter files.
* Fix typo in setuptools_scm
* Resolving requested changes.
* Fixing attributes for nxdl and yaml separately.
* REsolving PR comments
* Fixes Makefile pickung up nxdl rules for `make nyaml`
* Updating PR comments.
* updating PR comments.
* updating PR comments.
* updating PR comments.
* Replacing os, and xml from dependencies and add lxml and pathlib as dependencies.
* updating PR comments.
* Implementing black on nyal2nxdl converter files.
* Fixing test.
* Fixing build errors.
* Remove pyproject.toml and adapt makefile
* Remove $(DIRS) from nyaml command
* Updates a warning for using make nxdl
* Fix codestyle
* Build nxdl names from existing variables
* Fixing indentation miss alignment in comments commeing from nxdl to nyaml.
* Remove multiple build targets in Makefile
* Remove duplicate --do-not-store-nxdl
* Adjust variable names in generate_nxdl_or_retrieve_nxdl
* Update long_doc
* Align with nyaml2nxdl-migration branch
* Rename parameters to generate_nxdl_or_retrieve
* Align docstring
* Adds python setup step for ci/cd
* Fix test
* Skip package install in ci/cd
* Adds setup of python to build pages ci/cd
* Fix dimensions notation in NXcalibration.yaml
* Adapt NXidentifer and NXserialized to new nyaml2nxdl
---------
Co-authored-by: Sandor Brockhauser <sandor.brockhauser@xfel.eu>
Co-authored-by: Rubel <rubel.mozumder@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.