115 nyaml2nxdl xref edge cases #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requested during code camp
Updates ellipsometry manual page
Fairmat 2023 apm em cgms
Fixes automatic versioning
NXopt changes from NIAC proposal
Link first reference
…_definitions into fairmat_2023_pullback
…-proposal introductions and explanations which have now been replaced by the respective subgroups in contributed_classes, fixed typos, rerouted ci pipeline to point to fairmat branch
…of which the pdf did not compile properly
Fix rebase conflict. Fix rebase conflict. Disable fail-fast to check which versions work Actually *disable* fail-fast 🙈 Fix rebase conflict. Fix rebase conflict. Fix rebase conflict. Fix rebase conflict. Fix rebase conflict. Fix rebase conflict. Responding on PR review comments. Changes for PR review. Changes for PR review. Changes for PR review. Changes for PR review. Changes for PR review. Changes for PR review. Changes for PR revie.
Nyaml2nxdl migration add xref
|
prjemian
reviewed
Nov 10, 2023
| <!-- | ||
| # NeXus - Neutron and X-ray Common Data Format | ||
| # | ||
| # Copyright (C) 2008-2022 NeXus International Advisory Committee (NIAC) | ||
| # Copyright (C) 2014-2022 NeXus International Advisory Committee (NIAC) |
There was a problem hiding this comment.
Why is this copyright date changed? Are copyright dates in other NeXus classes also changed?
prjemian
reviewed
Nov 10, 2023
| @@ -285,7 +285,7 @@ def handle_each_part_doc(text): | |||
| Formated text | |||
| """ | |||
|
|
|||
| clean_txt = text.strip() | |||
| clean_txt = text.strip().strip('"') | |||
There was a problem hiding this comment.
Would removal of starting " use lstrip('"') instead?
Sorry, I don't know why this PR is open here. This is a current PR for the fairmat nexus repository (I only saw accidentally that it is opened here as well). This should only be contributed with #1303 or at a later stage. @RubelMozumder Was this PR accidentally created and if so can you close it here? |
prjemian
reviewed
Nov 13, 2023
| # Copyright (C) 2008-2022 NeXus International Advisory Committee (NIAC) | ||
| # | ||
| # | ||
| # Copyright (C) 2014-2023 NeXus International Advisory Committee (NIAC) |
There was a problem hiding this comment.
As stated elsewhere, do not change the copyright dates
|
It was created by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
termwill accept anything in-between aspaceandstandard.