Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding links to first references of the vocabulary items and support for collapsing doc strings #1337

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

sanbrock
Copy link
Contributor

created as a split from #1303

@sanbrock sanbrock added this to the NXDL 2023.10 milestone Dec 20, 2023
dev_tools/docs/nxdl.py Outdated Show resolved Hide resolved
dev_tools/tests/test_nxdl_utils.py Outdated Show resolved Hide resolved
dev_tools/tests/test_nxdl_utils.py Outdated Show resolved Hide resolved
dev_tools/utils/nxdl_utils.py Show resolved Hide resolved
@RussBerg
Copy link
Contributor

@sanbrock as requested on this mornings call I built the docs with this PR and it appears to not have broken the code for adding the contributors 👍 .

Incidentally you can build the docs locally with the contributors included if you create a github token then set the environment variable GH_TOKEN to that token string and it should see the token is defined and use it to retrieve the contributor information via the github API.

…port clarification, and file extension handling
@sanbrock
Copy link
Contributor Author

All comments are addressed

Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit 475c22a into main Jan 17, 2024
4 checks passed
@PeterC-DLS PeterC-DLS deleted the link_first_reference_2 branch February 8, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants