Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better rewrite of NXdata scaling_factor and offset fields #1343

Merged
merged 16 commits into from
Sep 5, 2024

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    650cfc1 View commit details
    Browse the repository at this point in the history
  2. Fix references

    phyy-nx committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1ddde5a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Code review

    Change NXdata scaling_factor to refer to "plotted" data
    Change NXdata to refer to "corrected" data, in addition to "physical" data, since it describes units of photons
    phyy-nx committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6c4b856 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Use FIELDNAME_scaling_factor and FIELDNAME_offset

    This resolves ambiguity if there is more than one signal
    
    For NXmx specify data_scaling_factor and data_offset since the field data is named in the NXdata group
    phyy-nx committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6ff76d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    f1f3dcb View commit details
    Browse the repository at this point in the history
  2. Apply comments from code review

    - NXmx: fully define pedestal, bias, and gain and how they relate to offset and scaling_factor
    - Add reserved suffixes _scaling_factor and _offset
    - NXdata: define better how the stored values in FIELDNAME are converted to physical values
    - NXdata: more clarification on how scaling_factor and offset without FIELDNAME are ambiguous
    phyy-nx committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    691f56a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Code review

    phyy-nx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7179988 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    9c52457 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. rank --> dimensions

    phyy-nx committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    edf4670 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Code review

    - NX_FLOAT -> NX_NUMBER for scaling_factor and offset
    - Sync language with number #1396 for the FIELDNAME convention
    phyy-nx committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9d4c4d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    48ed5ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3986074 View commit details
    Browse the repository at this point in the history
  3. Maybe fix build

    phyy-nx committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    80577e5 View commit details
    Browse the repository at this point in the history
  4. Attempt 2

    phyy-nx committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    37f53ac View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    314c763 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Spelling

    phyy-nx committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e8326dd View commit details
    Browse the repository at this point in the history