-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better rewrite of NXdata scaling_factor and offset fields #1343
Merged
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 650cfc1 - Browse repository at this point
Copy the full SHA 650cfc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ddde5a - Browse repository at this point
Copy the full SHA 1ddde5aView commit details
Commits on Jan 3, 2024
-
Change NXdata scaling_factor to refer to "plotted" data Change NXdata to refer to "corrected" data, in addition to "physical" data, since it describes units of photons
Configuration menu - View commit details
-
Copy full SHA for 6c4b856 - Browse repository at this point
Copy the full SHA 6c4b856View commit details
Commits on Jan 18, 2024
-
Use FIELDNAME_scaling_factor and FIELDNAME_offset
This resolves ambiguity if there is more than one signal For NXmx specify data_scaling_factor and data_offset since the field data is named in the NXdata group
Configuration menu - View commit details
-
Copy full SHA for 6ff76d6 - Browse repository at this point
Copy the full SHA 6ff76d6View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1f3dcb - Browse repository at this point
Copy the full SHA f1f3dcbView commit details -
Apply comments from code review
- NXmx: fully define pedestal, bias, and gain and how they relate to offset and scaling_factor - Add reserved suffixes _scaling_factor and _offset - NXdata: define better how the stored values in FIELDNAME are converted to physical values - NXdata: more clarification on how scaling_factor and offset without FIELDNAME are ambiguous
Configuration menu - View commit details
-
Copy full SHA for 691f56a - Browse repository at this point
Copy the full SHA 691f56aView commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7179988 - Browse repository at this point
Copy the full SHA 7179988View commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c52457 - Browse repository at this point
Copy the full SHA 9c52457View commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for edf4670 - Browse repository at this point
Copy the full SHA edf4670View commit details
Commits on Aug 19, 2024
-
- NX_FLOAT -> NX_NUMBER for scaling_factor and offset - Sync language with number #1396 for the FIELDNAME convention
Configuration menu - View commit details
-
Copy full SHA for 9d4c4d2 - Browse repository at this point
Copy the full SHA 9d4c4d2View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48ed5ef - Browse repository at this point
Copy the full SHA 48ed5efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3986074 - Browse repository at this point
Copy the full SHA 3986074View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80577e5 - Browse repository at this point
Copy the full SHA 80577e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f53ac - Browse repository at this point
Copy the full SHA 37f53acView commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 314c763 - Browse repository at this point
Copy the full SHA 314c763View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e8326dd - Browse repository at this point
Copy the full SHA e8326ddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.