Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxdlTypes: invalid xs:element for unit examples #1370

Closed
wants to merge 1 commit into from
Closed

nxdlTypes: invalid xs:element for unit examples #1370

wants to merge 1 commit into from

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Mar 9, 2024 •
edited
Loading

Closes #1368

This is not valid (see https://www.w3schools.com/xml/el_element.asp)

<xs:element name="example">rad</xs:element>

This PR proposes

<xs:element name="example" type="xs:string" fixed="rad"></xs:element>

This validator detected the issue:

import xmlschema
xmlschema.XMLSchema("nxdl.xsd")

Should we add this to the tests?

@woutdenolf woutdenolf linked an issue Mar 9, 2024 that may be closed by this pull request
nxdlTypes: invalid XML schema #1368
Open
@woutdenolf woutdenolf requested a review from prjemian March 9, 2024 10:47
@woutdenolf
Copy link
Contributor Author

Define an "example" element instead (#1368 (comment))

@woutdenolf woutdenolf closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian Awaiting requested review from prjemian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxdlTypes: invalid XML schema
1 participant
@woutdenolf