-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fairmat 2024: mention NXcoordinate_system in NXtransformations #1415
Open
lukaspie
wants to merge
10
commits into
nexusformat:main
Choose a base branch
from
FAIRmat-NFDI:fairmat-2024-nxtransformations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fairmat 2024: mention NXcoordinate_system in NXtransformations #1415
lukaspie
wants to merge
10
commits into
nexusformat:main
from
FAIRmat-NFDI:fairmat-2024-nxtransformations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
force-pushed
the
fairmat-2024-nxtransformations
branch
from
September 23, 2024 16:19
d5b73b5
to
677b6a1
Compare
Open
lukaspie
force-pushed
the
fairmat-2024-nxtransformations
branch
2 times, most recently
from
October 17, 2024 14:15
52e7bac
to
7f010d8
Compare
* Updates NXtransformations docs * Manually set to lower case true * Do a forward-backward nyaml cycle for NXtransformations # Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/NXtransformations.nxdl.xml # base_classes/nyaml/NXtransformations.yaml
lukaspie
added
NIAC vote needed
PR needs an approving vote from NIAC before merge
discussion needed
labels
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NXtransformation
AXISNAME
depends_on
, one can place either"."
, or the path to anNX_coordinate_system
Explanation of using
NXcoordinate_system
andNXtransformation
:NX_coordinate_system_set
contains one or more ofNXcoordinate_system
NXcoordinate_system
, there is adepends_on
, and(NXtransformation)
groupdepends_on
attribute or field links to aNXcoordinate_system
, it should pick the respectivedepends_on
field in that class, and apply the specifiedTRANSFORMATIONS
Example of how this is implemented in a (proposed) application definition: NXXps