Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add percent column component using intl formatter #622

Conversation

yvmunayev
Copy link
Contributor

#621

feat: add percent column component using intl formatter

@commit-lint
Copy link

commit-lint bot commented Oct 29, 2022

Features

  • add percent column component using intl formatter (e079939)
  • add cellAlignment prop (fa82165)

Bug Fixes

  • change title to container (2ace4f4)
  • useLocale import from react-rainbow-component (6bfc798)

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Oct 29, 2022

Visit the preview URL for this PR (updated for commit 2b13193):

https://rainbow-modules--pr622-feat-add-cell-percen-r6m5tvib.web.app

(expires Thu, 17 Nov 2022 21:40:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a8717bcb415e206776430df4c4296748001a9951

@LeandroTorresSicilia
Copy link
Member

@yvmunayev here we need to support cellAlignment prop defined in Column component thus we can align to left, center or right
Also percents by default must be aligned to right

@LeandroTorresSicilia LeandroTorresSicilia merged commit e5bfe3a into master Nov 10, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the feat-add-cell-percent-component-using-intl-formatter branch November 10, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants