-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl2 port #182
Closed
Closed
dsl2 port #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code works for ch_multiqc_custom_config - why not here?
* fastqc * picard/markduplicates * preseq/lcextrap * samtools/flagstat * samtools/index * samtools/stats * samtools/sort * trimgalore * multiqc
* bismark/genome_preparation * bismark/align * bismark/deduplicate * bismark/extract * bismark/report * bismark/summary TODO: write tests and add to nf-core/modules
* bwameth/align * bwameth/index TODO: write tests and add to nf-core/modules
* methyldackel/extract * methyldackel/mbias TODO: write tests and add to nf-core modules
TODO: write tests and add to nf-core/modules
TODO: write tests and add to nf-core/modules
this is inspired by the functionality in nf-core/nanoseq and nf-core/rnaseq The idea is to require a samplesheet to run the pipeline, which will allow for single/paired end auto-detection and mapping samples against different reference genomes. addresses nf-core#181
TODO: needs change in nf-core/test-datasets
baseDir is deprecated
Ah man! I will never get tired of seeing these initial DSL2 PRs appearing out of nowhere 😍 Looks great by just looking at the file changes! The fact that nf-core/modules will get more and more padded out is a huge bonus too! Nice work 🕺🏽 |
@drpatelh Your nf-core/rnaseq port was a very helpful guideline to figure out how to do things! Thanks for that 👍 |
This was referenced Jan 30, 2021
* methyldackel/extract * methyldackel/mbias TODO: write tests and add to nf-core modules
TODO: write tests and add to nf-core/modules
TODO: write tests and add to nf-core/modules
this is inspired by the functionality in nf-core/nanoseq and nf-core/rnaseq The idea is to require a samplesheet to run the pipeline, which will allow for single/paired end auto-detection and mapping samples against different reference genomes. addresses nf-core#181
TODO: needs change in nf-core/test-datasets
the pipeline now requires a samplesheet
remove conda and docker related actions
merging dsl2-template
closing this because there is now a dsl2 branch here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some initial effort on porting nf-core/methylseq to dsl2.
My aim was to retain the functionality that was already there, I think that all features from
v1.5
are working now.A breaking change however is, that the pipeline now requires a samplesheet similar to what is already used in nf-core/nanoseq for example. It is supposed to have 4 columns:
The idea behind this change is to enable mapping of samples against different references (#181), something that is very useful for certain use cases.
Bonus: the samplesheet makes the
single_end
parameter obsoleteWould be great to get some opinions on this @nf-core/core
TODOs:
options.args
to the module):methylseq/main.nf
Lines 585 to 615 in 031be37
MultiQC
module