Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ambiguity in the multilane sample information #452

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Removed ambiguity in the multilane sample information #452

merged 4 commits into from
Nov 28, 2024

Conversation

bounlu
Copy link

@bounlu bounlu commented Nov 1, 2024 •
edited
Loading

If there are samples from multiple lanes, the sample labels must be identical in the samplesheet so that they can be merged / concatenated before the analysis.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@bounlu bounlu requested a review from a team as a code owner November 1, 2024 08:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @bounlu,

It looks like this pull-request is has been made against the nf-core/methylseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/methylseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 4258f22

+| ✅ 200 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-28 07:47:06

@sateeshperi
Copy link
Contributor

@bounlu kindly change the base to dev and also could you make it a bit more clear saying if there are multilane samples it has to be represented in the way you described. Thanks

@bounlu
Copy link
Author

bounlu commented Nov 14, 2024 •
edited
Loading

@bounlu kindly change the base to dev and also could you make it a bit more clear saying if there are multilane samples it has to be represented in the way you described. Thanks

I added explanation as you suggested and changed the base to dev.

@bounlu bounlu changed the base branch from master to dev November 14, 2024 02:52
@sateeshperi sateeshperi merged commit d10699e into dev Nov 28, 2024
24 checks passed
@sateeshperi sateeshperi deleted the bounlu-patch-1 branch November 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger FelixKrueger is a code owner automatically assigned from nf-core/methylseq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bounlu @sateeshperi