SHAPEIT5_SWITCH Migrate to nf-test
#7066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPPearce
reviewed
Nov 25, 2024
Comment on lines
55
to
56
| file(params.modules_testdata_base_path + "delete_me/glimpse/1000GP.chr21.noNA12878.s.bcf",checkIfExists:true), | ||
| file(params.modules_testdata_base_path + "delete_me/glimpse/1000GP.chr21.noNA12878.s.bcf.csi",checkIfExists:true) |
There was a problem hiding this comment.
Can we please do something with this dataset on the test-data repository, rather than leave it in the delete_me folder? You've got multiple modules here using it.
There was a problem hiding this comment.
You're totally right.
I'll discuss it in the dedicated slack channel and update this pull request when done !
There was a problem hiding this comment.
Those files are also present on the phaseimpute branch of the test-datasets repository.
Should I use these files ?
sateeshperi
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Migration to nf-test for SHAPEIT5_SWITCH process.
Modified stub and update shapeit5 version to 5.1.1
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda