Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ampcombi 2.0.1 #7142

Merged
merged 18 commits into from
Dec 11, 2024
Merged

Conversation

Darcy220606
Copy link
Contributor

@Darcy220606 Darcy220606 commented Dec 2, 2024

PR checklist

This PR updates ampcombi2 from 0.2.2 to 2.0.1, which also fixes the issues encountered in nf-core/funcscan

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • [] Add a resource label
  • Use BioConda and BioContainers if possible to fullfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133
Copy link
Member

jfy133 commented Dec 11, 2024

@Darcy220606 said to wait because need to add a missing optional input for INterProScan

@Darcy220606
Copy link
Contributor Author

@Darcy220606 said to wait because need to add a missing optional input for InterProScan

@jfy133 all done now ✨ 👽 ✨

modules/nf-core/ampcombi2/parsetables/main.nf Outdated Show resolved Hide resolved
modules/nf-core/ampcombi2/parsetables/main.nf Outdated Show resolved Hide resolved
modules/nf-core/ampcombi2/parsetables/meta.yml Outdated Show resolved Hide resolved
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor corrections then I think good to go

modules/nf-core/ampcombi2/parsetables/main.nf Outdated Show resolved Hide resolved
modules/nf-core/ampcombi2/parsetables/main.nf Outdated Show resolved Hide resolved
modules/nf-core/ampcombi2/parsetables/main.nf Outdated Show resolved Hide resolved
modules/nf-core/ampcombi2/parsetables/main.nf Outdated Show resolved Hide resolved
modules/nf-core/ampcombi2/parsetables/meta.yml Outdated Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Dec 11, 2024

Merge away @Darcy220606 !

@Darcy220606 Darcy220606 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into nf-core:master with commit 993865f Dec 11, 2024
32 checks passed
@Darcy220606 Darcy220606 deleted the update_ampcombi2.0.1 branch December 11, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants