Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module: COPTR/ESTIMATE #7149

Merged
merged 10 commits into from
Dec 3, 2024
Merged

New module: COPTR/ESTIMATE #7149

merged 10 commits into from
Dec 3, 2024

Conversation

ramirobarrantes
Copy link
Contributor

PR checklist

  • Added new module: coptr/estimate
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

itrujnara
itrujnara reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, some minor things to address

modules/nf-core/coptr/estimate/main.nf
'biocontainers/coptr:1.1.4--pyhdfd78af_3' }"

input:
tuple val(meta), path(pkl, stageAs: "coverage_maps/*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be a directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, this tool is a bit particular that way...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

modules/nf-core/coptr/estimate/main.nf Outdated Show resolved Hide resolved
modules/nf-core/coptr/estimate/main.nf
touch ${prefix}.csv

cat <<-END_VERSIONS > versions.yml
"${task.process}":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many levels here

modules/nf-core/coptr/estimate/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/coptr/estimate/meta.yml Outdated Show resolved Hide resolved
@itrujnara itrujnara changed the title Initial addition New module: COPTR/ESTIMATE Dec 3, 2024
itrujnara
itrujnara approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramirobarrantes ramirobarrantes added this pull request to the merge queue Dec 3, 2024
@ramirobarrantes
Copy link
Contributor Author

Thank you very much!!

Merged via the queue into master with commit 47e81f6 Dec 3, 2024
35 checks passed
@ramirobarrantes ramirobarrantes deleted the coptr_estimate branch December 3, 2024 19:03
LouisLeNezet pushed a commit to LouisLeNezet/modules that referenced this pull request Dec 4, 2024
@ramirobarrantes @itrujnara
New module: COPTR/ESTIMATE (nf-core#7149)
cbeebc7 
* Initial addition

* Update modules/nf-core/coptr/estimate/main.nf

Co-authored-by: Igor Trujnara <53370556+itrujnara@users.noreply.github.com>

* Update modules/nf-core/coptr/estimate/meta.yml

Co-authored-by: Igor Trujnara <53370556+itrujnara@users.noreply.github.com>

* Update modules/nf-core/coptr/estimate/meta.yml

Co-authored-by: Igor Trujnara <53370556+itrujnara@users.noreply.github.com>

* Fixed levels

* Fixed levels issue, task.process was repeated twice

* Fixed levels issue, task.process was repeated twice

* Fixed levels issue, task.process was repeated twice

* Fixed levels issue, task.process was repeated twice

* Fixed levels issue, task.process was repeated twice

---------

Co-authored-by: Igor Trujnara <53370556+itrujnara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itrujnara itrujnara itrujnara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramirobarrantes @itrujnara