Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foldmason createdb #7180

Merged
merged 14 commits into from
Dec 10, 2024
Merged

Add foldmason createdb #7180

merged 14 commits into from
Dec 10, 2024

Conversation

luisas
Copy link
Contributor

@luisas luisas commented Dec 9, 2024

Add a module for creating the database by Foldmason

PR checklist

Closes #7179

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions

modules/nf-core/foldmason/createdb/main.nf Outdated Show resolved Hide resolved
modules/nf-core/foldmason/createdb/main.nf Outdated Show resolved Hide resolved
modules/nf-core/foldmason/createdb/main.nf Outdated Show resolved Hide resolved
modules/nf-core/foldmason/createdb/meta.yml Outdated Show resolved Hide resolved
luisas and others added 4 commits December 9, 2024 16:34
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@luisas luisas added this pull request to the merge queue Dec 10, 2024
Merged via the queue into nf-core:master with commit 0270c0f Dec 10, 2024
31 checks passed
@luisas luisas deleted the add_foldmason_createdb branch December 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: foldmason/createdb
2 participants