[jira] fix get username return empty string; Send messeage to correct…

… channel.
ngdinhtoan · Jun 23, 2015 · 30caed1 · 30caed1
1 parent 26cb40f
commit 30caed1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/jira/client.go b/jira/client.go
@@ -34,7 +34,7 @@ func getMarkdownUsername(user *jc.User) string {
 	}
 
 	var name string
-	if name := user.DisplayName; name == "" {
+	if name = user.DisplayName; name == "" {
 		name = user.Name
 	}
 

diff --git a/jira/ticket.go b/jira/ticket.go
@@ -46,11 +46,7 @@ func (t *ticket) Execute(payload *slackcmd.Payload, w http.ResponseWriter) error
 
 	whPayload := webhook.NewPayload()
 	whPayload.Text = fmt.Sprintf("`%s %s`", payload.Command, payload.Text)
-	if payload.IsPrivateGroup() == false {
-		whPayload.Channel = "#" + payload.ChannelName
-	} else {
-		//todo: get channel name by channel ID via Slack API!?
-	}
+	whPayload.Channel = payload.ChannelID
 
 	wg := &sync.WaitGroup{}
 	lk := &sync.Mutex{}
@@ -79,7 +75,7 @@ func (t *ticket) Execute(payload *slackcmd.Payload, w http.ResponseWriter) error
 
 	wg.Wait()
 
-	webhook.SendMessage(whPayload)
+	go webhook.SendMessage(whPayload)
 
 	var err error
 	if len(notFoundIssues) > 0 {