Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: Remove IFDs #41

Merged
merged 3 commits into from
Aug 25, 2023
Merged

treewide: Remove IFDs #41

merged 3 commits into from
Aug 25, 2023

Conversation

Relates to:
 - #24
 - #39
 - #40
Copy link
Contributor

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kikit stuff LGTU (@ngi-nix/fungus)! Thanks for dealing with it. We actually had to remove IFD when we submitted this stuff to try to upstream it to nixpkgs in NixOS/nixpkgs#249464, sorry for the duplicated work!

pkgs/kikit/solidpython/default.nix Outdated Show resolved Hide resolved
@lorenzleutgeb lorenzleutgeb marked this pull request as ready for review August 25, 2023 12:45
Copy link
Collaborator

@cleeyv cleeyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me! The only thing I see missing is to replace the use of liberaforms as an example in the README for adding and deploying a service: https://github.com/ngi-nix/ngipkgs/blob/main/README.md?plain=1#L43-L49

I think pretalx would be an excellent alternative to liberaforms in this section. It doesn't need to be exactly the same things covered, you can just copy what you've already put in your README for pretalx, so it could be changed to "Add and test a service" and we can include more about deployment later.

I'm working now on making this edit to the README using the pretalx example, hopefully a commit coming soon.

@lorenzleutgeb lorenzleutgeb merged commit f509d16 into main Aug 25, 2023
2 checks passed
@lorenzleutgeb lorenzleutgeb deleted the no-ifd branch August 25, 2023 22:45
@mightyiam
Copy link
Member

Nooice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: mobleted
Development

Successfully merging this pull request may close these issues.

4 participants