Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run all modules builds in parallel. #22

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

thresheek
Copy link
Member

The previous approach with building all modules builds on a same VM works fine, however the disk space on a single GHA runner is limited and not enough anymore on select targets.

@thresheek thresheek requested a review from oxpa December 17, 2024 22:42
@oxpa
Copy link
Contributor

oxpa commented Dec 27, 2024

NGINX_VERSION=$(make --eval 'nv:; @echo $(BASE_VERSION)' nv)

This can probably be done by sourcing contrib/src/nginx/version

dnf -y install $(rpmspec -P ./${spec} | grep BuildRequires | cut -d: -f2- | xargs)

And this is dnf -y builddep ${spec} in most cases. Or yum-builddep ${spec}. Though thinking about this - I'm not sure if the latter needs -y flag

@thresheek
Copy link
Member Author

Sourcing the file doesnt work:

$ basename $(pwd)
pkg-oss
$ . contrib/src/nginx/version
dash: 1: contrib/src/nginx/version: NGINX_VERSION: not found
dash: 2: contrib/src/nginx/version: NGINX_PLUS_VERSION: not found

The previous approach with building all modules builds on a same VM
works fine, however the disk space on a single GHA runner is limited and
not enough anymore on select targets.
@thresheek
Copy link
Member Author

And this is dnf -y builddep ${spec} in most cases.

Woah, I had no idea! Implemented that instead of an ugly way I had before.

@thresheek thresheek merged commit 1fd6752 into nginx:master Jan 3, 2025
57 checks passed
@thresheek thresheek deleted the ci-parallel branch January 3, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants