Updates for otel module #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxpa
reviewed
Dec 27, 2024
|
I think I'll rework this PR to postpone bumping grpc (and maybe some other dependencies), since they seem to inflate the binary size. |
It's not really needed since d70ec9f, and failure to detect it breaks build on Alpine 3.21.
This is not something that currently matters, but future versions of protobuf require abseil as a build dependency.
|
Yeah, it looks like bumping abseil-cpp leads to bumping protobuf leads to bumping grpc; so all of those will need to be postponed If we would want the updates. We dont need them since they don't seem to fix any logic or security issues, so we're safe there. |
thresheek
force-pushed
the
otel-updates-2
branch
from
e675499 to
61f8214
Compare
|
Disregard, seems like we need some more build dependencies preinstalled on our build farm |
Notable exception is Alpine 3.18, which is due to EOL in May 2025, which ships a too old protobuf.
thresheek
force-pushed
the
otel-updates-2
branch
from
61f8214 to
430cf01
Compare
|
Yeah, turns out protobuf is too old on Alpine 3.18, so I added a hacky way to detect it in the APKBUILD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes include:
- grpc & dependencies updated to latest versions