Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow otel module directives #75

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Allow otel module directives #75

merged 1 commit into from
Oct 10, 2023

Conversation

puneetsarna
Copy link
Contributor

@puneetsarna puneetsarna commented Oct 9, 2023

https://nginx.org/en/docs/ngx_otel_module.html

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@puneetsarna puneetsarna requested a review from a team as a code owner October 9, 2023 23:59
@ornj
Copy link
Member

ornj commented Oct 10, 2023

There are already directives from dynamic modules in crossplane (notably NJS), but the point has been made in the past that perhaps these should be "add ons" rather than included in the core map in analysis.go. I think this has some merit as you could "customize" crossplane to be aware of whatever non-standard modules you are using.

This could allow using crossplane with unknown 3rd party modules or better support those that allow configurations that can look very different from the usual NGINX configs (Lua).

Since there are already directives from "first party" nginx modules in crossplane, I think move forward with reviewing and merging this PR.

analyze.go Outdated Show resolved Hide resolved
@puneetsarna puneetsarna enabled auto-merge October 10, 2023 19:35
@puneetsarna puneetsarna merged commit 928942a into main Oct 10, 2023
2 checks passed
@puneetsarna puneetsarna deleted the ps-dev-otel branch October 10, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants