Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ngx_mgmt_module #88

Merged
merged 2 commits into from
May 17, 2024
Merged

Support ngx_mgmt_module #88

merged 2 commits into from
May 17, 2024

Conversation

dakshinai
Copy link
Contributor

Proposed changes

Adding support for ngx_mgmt_module

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dakshinai dakshinai requested a review from a team as a code owner May 15, 2024 19:13
dakshinai
dakshinai commented May 15, 2024
View reviewed changes
analyze.go Outdated Show resolved Hide resolved
@dakshinai dakshinai requested a review from ornj May 15, 2024 19:23
@dakshinai dakshinai force-pushed the nlb-4310-support-ngx_mgmt_module branch from ed18d59 to 3f8fbfc Compare May 16, 2024 01:10
dakshinai
dakshinai commented May 16, 2024
View reviewed changes
analyze.go Outdated Show resolved Hide resolved
@dakshinai dakshinai force-pushed the nlb-4310-support-ngx_mgmt_module branch from 3f8fbfc to 4ec3c8e Compare May 16, 2024 18:47
ornj
ornj reviewed May 16, 2024
View reviewed changes
analyze.go Outdated Show resolved Hide resolved
@dakshinai dakshinai force-pushed the nlb-4310-support-ngx_mgmt_module branch from 4ec3c8e to 12d4eee Compare May 16, 2024 21:25
@dakshinai dakshinai requested review from ryepup and UnwashedMeme May 17, 2024 17:24
@dakshinai dakshinai force-pushed the nlb-4310-support-ngx_mgmt_module branch from 12d4eee to 0720f34 Compare May 17, 2024 22:20
@dakshinai dakshinai force-pushed the nlb-4310-support-ngx_mgmt_module branch from 98c5ea4 to 0576717 Compare May 17, 2024 22:29
@dakshinai dakshinai merged commit 5f46130 into nginxinc:main May 17, 2024
2 checks passed
@dakshinai dakshinai deleted the nlb-4310-support-ngx_mgmt_module branch May 17, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xynicole xynicole xynicole approved these changes

@ornj ornj ornj approved these changes

@ryepup ryepup Awaiting requested review from ryepup

@UnwashedMeme UnwashedMeme Awaiting requested review from UnwashedMeme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakshinai @ornj @xynicole