-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#865-upgrade-three-js #1002
#865-upgrade-three-js #1002
Commits on Mar 17, 2024
-
Only BufferGeometry is supported. Every BufferGeometry helper (e.g. BoxBufferGeometry) has been renamed to shorter name (e.g. BoxGeometry)
Configuration menu - View commit details
-
Copy full SHA for 0f1d1d4 - Browse repository at this point
Copy the full SHA 0f1d1d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 417345b - Browse repository at this point
Copy the full SHA 417345bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3295839 - Browse repository at this point
Copy the full SHA 3295839View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5378d1 - Browse repository at this point
Copy the full SHA e5378d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f4686 - Browse repository at this point
Copy the full SHA 65f4686View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24c0886 - Browse repository at this point
Copy the full SHA 24c0886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82a77d9 - Browse repository at this point
Copy the full SHA 82a77d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71d6d4b - Browse repository at this point
Copy the full SHA 71d6d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f919994 - Browse repository at this point
Copy the full SHA f919994View commit details -
Configuration menu - View commit details
-
Copy full SHA for baf2422 - Browse repository at this point
Copy the full SHA baf2422View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26bee39 - Browse repository at this point
Copy the full SHA 26bee39View commit details -
upgrade dev dependencies to pass npm audit
critical and high vulnerabilities were caused by dependencies related with Jest
Configuration menu - View commit details
-
Copy full SHA for dd7507d - Browse repository at this point
Copy the full SHA dd7507dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8219f6c - Browse repository at this point
Copy the full SHA 8219f6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1355891 - Browse repository at this point
Copy the full SHA 1355891View commit details -
revert 356d957: delete Volume._position in setData()
Previous code was setting `_position` to an empty array. This was causing some bugs where the _position array was not filled with the proper values and remained empty.
Configuration menu - View commit details
-
Copy full SHA for d24ea77 - Browse repository at this point
Copy the full SHA d24ea77View commit details -
r132 ALPHATEST --> USE_ALPHATEST
`ALPHATEST` was previously used as a flag and a value in three.js `alphatest_fragment` chunk. It was superseded by the `USE_ALPHATEST` flag and the `alphaTest` value passed as a uniform. The declaration of the `alphaTest` uniform is made in the `alphatest_pars_fragment` chunk.
Configuration menu - View commit details
-
Copy full SHA for e173521 - Browse repository at this point
Copy the full SHA e173521View commit details -
SpotLight --> DirectionalLight
A SpotLight must have its distance set in real world coordinates. This was resulting in very dark scenes, where the position of the light or its intensity must take into account the bounding box. Directional Lights do not require this settings. They light the scene in a uniform manner from afar.
Configuration menu - View commit details
-
Copy full SHA for f9802b2 - Browse repository at this point
Copy the full SHA f9802b2View commit details -
Adjust default light intensity
3.14 is the value recommanded in Three.js documentation when converting colorspaces Ambient intensity of 1 is the default.
Configuration menu - View commit details
-
Copy full SHA for f35f574 - Browse repository at this point
Copy the full SHA f35f574View commit details -
set colorspace to three.js defaults
By default the outputColorSpace is set to rgb. Internal colors are set to linear rgb space. `compositeMaterial` derives from custom ShaderMaterial. Correct color depends on the `colorspace_fragment` chunk beign executed in the corresponding fragment shader.
Configuration menu - View commit details
-
Copy full SHA for 3843e91 - Browse repository at this point
Copy the full SHA 3843e91View commit details -
original value was 0.2. Recommended multiplicator is PI and 0.63 seems to give comparable results with the previous version.
Configuration menu - View commit details
-
Copy full SHA for 16c7e47 - Browse repository at this point
Copy the full SHA 16c7e47View commit details -
convert fog color to linear colorspace
The pattern here is that when a color is set as a string or an hex number, it requires conversion from RGB to linear. On contrary, if a color is set via a Color object, it is assumed that this one is already encoded in linear color space.
Configuration menu - View commit details
-
Copy full SHA for 4921bab - Browse repository at this point
Copy the full SHA 4921babView commit details -
Remove unused colorspace properties
Because we are now using Three.js defaults
Configuration menu - View commit details
-
Copy full SHA for d67eb50 - Browse repository at this point
Copy the full SHA d67eb50View commit details -
convert color when appending to uniforms array
ColorMakers are called when creating BufferArrays to populate the `color` uniform. 4 methods can be applied (atomColorToArray, bondColorToArray, volumeColorToArray, positionColorToArray). Each of these, calls a related method (e.g. `atomColor`) to get a color that is defined in RGB Colorspace, encoded as an integer between 0 and 2**24. This color is then converted to a tuple of 3 values which are passed along all the other vertices colors to the shaders codes as a uniform. Prior code was using a decorator to convert the output color of each coloring function, to linear space and then to hex. This hex value was then later processed to be split and normalized in the array buffer. The change here makes the linearization at the last step, after the normalization which should avoid clamping due to the double conversion that was happening previously
Configuration menu - View commit details
-
Copy full SHA for e3ad21a - Browse repository at this point
Copy the full SHA e3ad21aView commit details -
Fix banding appearing after antialiasing
A banding effect was due to a loss of precision when copying the texture between render targets as linear encoding requires more precision.
Configuration menu - View commit details
-
Copy full SHA for 3772790 - Browse repository at this point
Copy the full SHA 3772790View commit details -
It seems the relative units might have changed between the camera and the point of focus. Pushing the fog near plane further back, seems to visually match with previous version results.
Configuration menu - View commit details
-
Copy full SHA for 48c0db6 - Browse repository at this point
Copy the full SHA 48c0db6View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b5a3523 - Browse repository at this point
Copy the full SHA b5a3523View commit details
Commits on Apr 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d018310 - Browse repository at this point
Copy the full SHA d018310View commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b09d478 - Browse repository at this point
Copy the full SHA b09d478View commit details