#865 upgrade three js legacy lights #1037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Three.js dependency to a more recent version, which still supports the legacy color management. It derives from the #1002 PR which was attempting at migrating the internal color management to a complete linear workflow.
As the current version of Three.js in the codebase raises (unjustified) alerts from npm audit and other dependency alert bots, this intermediary upgrade is somehow necessary.
The
standard
library dev dependency has been upgraded as well as 'Jest'.standard
is seldom used at the moment, as it does not lint ts files.Known issues
ambientIntensity
) and directional lighting (lightIntensity
) have been increased to mimic the previous rendering (respectively 0.2 --> 0.3, 1 --> 1.2). This means that users who have custom lighting presets will have to tweak them after the update.standard
. This is because the linter does not find any js file in the src directory. I've commented-out the linting commands for now.