Skip to content
This repository has been archived by the owner on Jan 10, 2018. It is now read-only.

Support factory function for _initialState parameter of provideStore #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iron9light
Copy link

ngc does not support function call now. It will be good to support passing a function parameter to provideStore.

@robwormald
Copy link
Contributor

Can you add an integration test for this? and be sure to squash your commits.

ngc does not support function call now. It will be good to support passing a function parameter to provideStore.
@iron9light
Copy link
Author

@robwormald updated based on your comments.

@brandonroberts
Copy link
Member

@robwormald is this still valid?

@shprink
Copy link
Contributor

shprink commented Feb 1, 2017

this is very much needed. though I am not sure if AoT could be a problem here.

@tomazy
Copy link

tomazy commented Jun 7, 2017

@robwormald could we get this merged please? This PR seems to fix the issues with AoT compilation in the latest Angular 4. I'm trying to use this great lib in a universal app and this PR would help us greatly to move forward.

@alan-agius4
Copy link

This is a must have, I dont know why its taking so long for them to merge

@tomazy
Copy link

tomazy commented Jun 8, 2017

It looks that this repo is not maintained any more and the project has move to ngrx/platform.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants