md fixes #30
Merged
md fixes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (!A AND B) then assign A = true is equivalent to A |= B (A is only false when A and B are false in both cases) tests pass as well
|
i kept the clippy error messages. |
nickspring
reviewed
Oct 4, 2023
Don't see it in changes, only in commit. It looks correct. |
A or false -> A
if false { A } else {B}
-> B
we had an intermediate owner `decoded_payload_result` but it is unnecessary.
prioritized_encodings does not need to own a String
otherwise we unwrap the error message and return true since it is ascii..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strips should_strip_sig_or_bom
some blackmagic boolean logic 4899bf3
I doubled checked this with pen and paper, and tests all pass
But still it would be a good idea to get another set of eyes here.