Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned before, i prepared a PR that replaces
unic
from the codebase.a non exhaustive list of reasons to change :
Through this PR, now Unicode 15 is supported.
I haven't seen any regressions from
--bin performance
orcargo bench
.Since
icu4x
is actively being developed I expect that there would be more features includingname
orunicode ranges
implementations or speedups. Unfortunately there is no speedup observed at the moment, buticu4x
is actively tracking and performance regressions and striving to improve it as well.Also I hope to make further idiomatic changes especially around the
md
module upon this platform.I know this is a big change, but hopefully it will lead to easier development and reduced hardcoding down the road.
Take your time reviewing it and feel free to ask any questions.