Add support for numpy v2 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy v2.0.0 contains backwards ABI compatibility machinery to work with numpy v1.xx at runtime (possibly as far back at v1.19)
This version is guaranteed to work with numpy v2 ABI builds.
While we could use the new name numpy.trapezoid, it would require runtime checks on numpy version to select the correct name when using numpy v1 or v2. Instead replace with scipy.integrate.trapezoid since we depend on scipy already and is an equivalent function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should provide the required changes for ARC to build against numpy v2 (which provides backwards compatibility for v1.x at runtime). Exception is for python 3.8, which does not appear to have numpy v2 support. I have explicitly confirmed that local installations function for numpy==2.0 and numpy==1.23 under python=3.11.
As far as source code changes, ARC only required a single function change due to the re-naming of
np.trapztonp.trapezoid. Unfortunately, supporting that name change would require a runtime check based on the numpy version. As a simpler choice, I moved those calls toscipy.integrate.trapezoidwhich should be completely equivalent.Fixes #178 (and other similar questions)
References:
Numpy 2.0 migration guide
Depending on numpy - 2.0 advice
SciPy Developer Advice for NumPy