Skip to content

Commit

Permalink
Clean up some legacy code and improve build (deephaven#4674)
Browse files Browse the repository at this point in the history
* Avoid extra copy of TypeScript/JavaScript files in proto/raw-js-openapi/Dockerfile

* Delete FishUtil. All usages have been eliminated, trivially inlined, or the files have migrated to more appropriate modules.

* Refactor TrackedFileHandleFactory to use a ScheduledExecutorService instead of Scheduler

* Refactor Liveness to use a ScheduledExecutorService instead of Scheduler for (currently unused) scheduleCountReport

* Replace Scheduler usage in PeriodicUpdateGraph with ScheduledExecutorService. Standardize on nanoseconds for timing. Eliminate unnecessary initializations.

* Replace Scheduler usage in StatsDriver with ScheduledExecutorService

* Delete :Net. Delete io.sched package. Delete gradle :Net and fishnet projects/configurations. Delete dependencies on same.

* Delete legacy utility that used reflection to reach into the guts of SelectorImpl

---------

Co-authored-by: Colin Alworth <colinalworth@deephaven.io>
  • Loading branch information
rcaudy and niloc132 committed Nov 30, 2023
1 parent 7e596a6 commit e719136
Show file tree
Hide file tree
Showing 58 changed files with 173 additions and 4,481 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,10 @@
package io.deephaven.base.stats;

public interface ItemUpdateListener {
public void handleItemUpdated(Item item, long now, long appNow, int intervalIndex, long intervalMillis,
String intervalName);

public static final ItemUpdateListener NULL = new ItemUpdateListener() {
public void handleItemUpdated(Item item, long now, long appNow, int intervalIndex, long intervalMillis,
String intervalName) {
// empty
}
void handleItemUpdated(
Item<?> item, long now, long appNow, int intervalIndex, long intervalMillis, String intervalName);

ItemUpdateListener NULL = (item, now, appNow, intervalIndex, intervalMillis, intervalName) -> {
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void testSample() throws Exception {
// should have a count of 1 in bin[1]..bin[63]; bin[0]=2

Stats.update(new ItemUpdateListener() {
public void handleItemUpdated(Item item, long now, long appNow, int intervalIndex, long intervalMillis,
public void handleItemUpdated(Item<?> item, long now, long appNow, int intervalIndex, long intervalMillis,
String intervalName) {
// Value v = item.getValue();
HistogramPower2 nh;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public void testSample() throws Exception {
// This should print 10 invocations every time

Stats.update(new ItemUpdateListener() {
public void handleItemUpdated(Item item, long now, long appNow, int intervalIndex, long intervalMillis,
public void handleItemUpdated(Item<?> item, long now, long appNow, int intervalIndex, long intervalMillis,
String intervalName) {
Value v = item.getValue();
History history = v.getHistory();
Expand Down
14 changes: 0 additions & 14 deletions FishUtil/build.gradle

This file was deleted.

89 changes: 0 additions & 89 deletions FishUtil/cpp/MicroTimer.cpp

This file was deleted.

22 changes: 0 additions & 22 deletions FishUtil/cpp/MicroTimer.h

This file was deleted.

9 changes: 0 additions & 9 deletions FishUtil/cpp/SignalUtils.cpp

This file was deleted.

21 changes: 0 additions & 21 deletions FishUtil/cpp/SignalUtils.h

This file was deleted.

1 change: 0 additions & 1 deletion FishUtil/gradle.properties

This file was deleted.

Loading

0 comments on commit e719136

Please sign in to comment.