Skip to content

Commit

Permalink
fix unix stdlib install location after #21328 (#24460)
Browse files Browse the repository at this point in the history 
closes #22369, closes #23197, closes #24385, refs #21328

According to #21328 the standard library on Unix should be installed in
`/usr/lib/nim/lib`, however the installer was not updated for this
change, hence the problem as described in
#23197 (comment).

Have not tested if this fixes the problem but the comment heavily
implies it does. The problem is also in 2.0 so it could be backported
but I can't say for sure that it works and doesn't break anything.
  • Loading branch information
@metagn
metagn authored Nov 22, 2024
1 parent 9fcc3b0 commit 33e455c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/niminst/install.nimf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ if [ $# -eq 1 ] ; then
"/usr/bin")
bindir=$1
configdir="/etc/?proj"
libdir="/usr/lib/?proj"
libdir="/usr/lib/?proj/lib"
docdir="/usr/share/?proj/doc"
datadir="/usr/share/?proj/data"
nimbleDir="/opt/nimble/pkgs/?c.nimblePkgName-?c.version"
;;
"/usr/local/bin")
bindir=$1
configdir="/etc/?proj"
libdir="/usr/local/lib/?proj"
libdir="/usr/local/lib/?proj/lib"
docdir="/usr/local/share/?proj/doc"
datadir="/usr/local/share/?proj/data"
nimbleDir="/opt/nimble/pkgs/?c.nimblePkgName-?c.version"
Expand Down

1 comment on commit 33e455c

@c-blake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I have been installing the stdlib in /usr/lib/nim/lib (and the binaries in /usr/lib/nim/bin/nimsuggest, for example) for like 10 years on Gentoo Linux. Impossible to say if this broke anything that wouldn't have been broken already without an actual A/B test, of course, and also hard to assess fragility of the many, many other Linux distros.

Please sign in to comment.