-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add an additional environment to tox
to run notebooks
#257
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 19 19
Lines 942 942
Branches 119 119
=======================================
Hits 624 624
Misses 274 274
Partials 44 44 ☔ View full report in Codecov by Sentry. |
What's the old and new runtime? If they're long running, I'd suggest a new tox environment. If it's not a significant addition, this seems fine. |
8e6e5e9
to
8a95480
Compare
I see; before it was around 6 minutes, but after reading your comment I believe that it is better to add a new environment event if the running time is not that long.
Edit: Working now. The notebook is failing because we have not uploaded the data that is requires somewhere to be able to share and use it: |
e061416
to
a608c43
Compare
Add an additional environment to `tox` to run notebooks. Add a new table to `pyproject.toml` to host the `jupyter`, `nbconvert` and `nbclient` dependencies so that the notebooks can be run.
a608c43
to
5426789
Compare
tox
testing steptox
to run notebooks
Add an additional environment to
tox
to run notebooks.Add a new table to
pyproject.toml
to host thejupyter
,nbconvert
andnbclient
dependencies so that the notebooks can be run.